-
Notifications
You must be signed in to change notification settings - Fork 15
STRIPES-861: Setup module federation #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mkuklis
wants to merge
7
commits into
main
Choose a base branch
from
STRIPES-861
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
752757c
STRIPES-861: Setup federation
mkuklis 7259755
Introduce port argument
mkuklis 371aee2
Merge branch 'main' into STRIPES-861
JohnC-80 e5ddab3
Merge branch 'main' into STRIPES-861
JohnC-80 b618318
Merge branch 'main' into STRIPES-861
JohnC-80 f0b5459
log changes
JohnC-80 1f51cc9
resolve conflicts on CHANGELOG
JohnC-80 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| const importLazy = require('import-lazy')(require); | ||
|
|
||
| const { contextMiddleware } = importLazy('../cli/context-middleware'); | ||
| const StripesCore = importLazy('../cli/stripes-core'); | ||
| const StripesPlatform = importLazy('../platform/stripes-platform'); | ||
| const { stripesConfigFile } = importLazy('./common-options'); | ||
|
|
||
| let _stripesPlatform; | ||
| let _stripesCore; | ||
|
|
||
| // stripesPlatform and stripesCore overrides primarily used as injection for unit tests | ||
| function stripesOverrides(stripesPlatform, stripesCore) { | ||
| _stripesPlatform = stripesPlatform; | ||
| _stripesCore = stripesCore; | ||
| } | ||
|
|
||
| function federateCommand(argv) { | ||
| const context = argv.context; | ||
| // Default federate command to production env | ||
| if (!process.env.NODE_ENV) { | ||
| process.env.NODE_ENV = 'production'; | ||
| } | ||
|
|
||
| const platform = _stripesPlatform || new StripesPlatform(argv.stripesConfig, context, argv); | ||
| const webpackOverrides = []; | ||
|
|
||
| if (argv.analyze) { | ||
| const BundleAnalyzerPlugin = require('webpack-bundle-analyzer').BundleAnalyzerPlugin; // eslint-disable-line | ||
| webpackOverrides.push((config) => { | ||
| config.plugins.push(new BundleAnalyzerPlugin()); | ||
| return config; | ||
| }); | ||
| } | ||
|
|
||
| console.info('Federate module...'); | ||
| const stripes = _stripesCore || new StripesCore(context, platform.aliases); | ||
| stripes.api.federate(Object.assign({}, argv, { webpackOverrides })); | ||
| } | ||
|
|
||
| module.exports = { | ||
| command: 'federate', | ||
| describe: 'federate single module', | ||
| builder: (yargs) => { | ||
| yargs | ||
| .middleware([ | ||
| contextMiddleware(), | ||
| ]) | ||
| .positional('configFile', stripesConfigFile.configFile) | ||
| .option('analyze', { | ||
| describe: 'Run the Webpack Bundle Analyzer after build (launches in browser)', | ||
| type: 'boolean', | ||
| }) | ||
| .option('port', { | ||
| describe: 'A port which will be used for the remote federated module', | ||
| type: 'number', | ||
| }) | ||
| .example('$0 federate', 'federate a module'); | ||
| }, | ||
| handler: federateCommand, | ||
| stripesOverrides, | ||
| }; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, this was reverted