STRIPES-861-int - Integration of Module Federation feature. #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld and serve commands
|
zburke
approved these changes
Jan 15, 2026
| ]) | ||
| .positional('configFile', stripesConfigFile.configFile) | ||
| .option('federate', { | ||
| describe: 'At platform level, serves an empty host platform, using configured entitlementUrl to procure a list or remote apps. At the module level, this registers/serves the app as a locally federated remote.', |
Member
There was a problem hiding this comment.
typos: "At THE platform...", "a list OF..."
"At the platform level": it also spins up a local registry, right? Should we say that?
| function start(dir, options) { | ||
| const app = express(); | ||
| app.use(express.json()); | ||
| app.use(cors()); |
Member
There was a problem hiding this comment.
Wide-open cors() makes Sonar grumpy. Do we think Sonar is correct here and we should limit dev-stuff to localhost, or do we want to leave it wide-open, knowing that it's insecure from some points of view but ack'ing that this is how things go during development when we don't have all those configurations ironed out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this update, we shift the POC code to conform to current
stripes-cliAPI.The
buildcommands build to anoutputdirectory by default.At the workspace level with
stripes-core,stripes-connect,stripes-components: (assuming that's where the config file is)Build a module-federation host app:
Serve the host app (dev mode)
At the ui-module level (Builds module bundle for static hosting)
Serving the federated ui-module (dev mode)
Some
serverfeatures have been updated for sake of serving the host app so that it can further be loaded into a separately hosted 'hub'.