Skip to content

Comments

UINV-619 Use the same component for the subscriptionStart and subscriptionEnd fields#918

Merged
usavkov-epam merged 2 commits intomasterfrom
UINV-619
Jan 23, 2026
Merged

UINV-619 Use the same component for the subscriptionStart and subscriptionEnd fields#918
usavkov-epam merged 2 commits intomasterfrom
UINV-619

Conversation

@usavkov-epam
Copy link
Contributor

@usavkov-epam usavkov-epam commented Jan 23, 2026

Purpose

https://folio-org.atlassian.net/browse/UINV-619

When there is more than one invoice line associated with a POL, the Other related invoice lines accordion shows up on an invoice line during invoice creation. This is helpful for reviewing related order line history for ongoing orders. Something is off with the Subscription start and Subscription end dates, however, as they are all displaying with values one day earlier than the actual dates input.

Approach

Use component consistent with https://github.com/folio-org/ui-invoice/blob/master/src/invoices/InvoiceLineDetails/InvoiceLineInformation.js#L83-L92

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

@usavkov-epam usavkov-epam self-assigned this Jan 23, 2026
@github-actions
Copy link

github-actions bot commented Jan 23, 2026

Jest Unit Test Results

  1 files  ±0  132 suites  ±0   4m 7s ⏱️ +23s
500 tests ±0  500 ✅ ±0  0 💤 ±0  0 ❌ ±0 
507 runs  ±0  507 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 66e0ab3. ± Comparison against base commit 29c634d.

♻️ This comment has been updated with latest results.

@sonarqubecloud
Copy link

@usavkov-epam usavkov-epam requested review from a team January 23, 2026 08:55
@NikitaSedyx NikitaSedyx requested a review from a team January 23, 2026 14:39
@usavkov-epam usavkov-epam merged commit e1f6193 into master Jan 23, 2026
15 checks passed
@usavkov-epam usavkov-epam deleted the UINV-619 branch January 23, 2026 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants