Skip to content

Comments

UIOR-1513: Fix permission error for custom-fields#1835

Open
elsenhans wants to merge 5 commits intomasterfrom
UIOR-1513
Open

UIOR-1513: Fix permission error for custom-fields#1835
elsenhans wants to merge 5 commits intomasterfrom
UIOR-1513

Conversation

@elsenhans
Copy link
Contributor

@elsenhans elsenhans commented Feb 17, 2026

https://folio-org.atlassian.net/browse/UIOR-1513

Purpose
Fix permission error for custom-fields.

Approach
Add subPermissions mod-settings.entries.item.post and mod-settings.entries.item.put to ui-orders.settings.custom-fields.edit

Screenshots

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@elsenhans elsenhans requested a review from a team February 17, 2026 10:42
@github-actions
Copy link

github-actions bot commented Feb 17, 2026

Jest Unit Test Results

    1 files  ±0    295 suites  ±0   7m 10s ⏱️ -33s
1 002 tests ±0    994 ✅ ±0  8 💤 ±0  0 ❌ ±0 
1 010 runs  ±0  1 002 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit e2bb668. ± Comparison against base commit 8fd4ee8.

♻️ This comment has been updated with latest results.

@elsenhans elsenhans requested a review from alb3rtino February 17, 2026 14:33
@elsenhans elsenhans marked this pull request as draft February 17, 2026 14:40
@elsenhans elsenhans removed the request for review from a team February 17, 2026 14:40
@elsenhans elsenhans changed the title UIOR-1513 UIOR-1513: Fix permission error for custom-fields Feb 18, 2026
@elsenhans elsenhans marked this pull request as ready for review February 18, 2026 08:11
@elsenhans elsenhans requested a review from a team February 18, 2026 08:12
@SerhiiNosko SerhiiNosko requested a review from a team February 18, 2026 09:06
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants