Skip to content

Conversation

@Dmytro-Melnyshyn
Copy link
Contributor

@Dmytro-Melnyshyn Dmytro-Melnyshyn commented Jan 14, 2026

Purpose

Settings are migrated from users/configurations/entry to users/settings/entries. Update getting the profile picture config.

Issues

https://folio-org.atlassian.net/browse/UIU-3506

Approach

TODOS and Open Questions

Learning

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@github-actions
Copy link

github-actions bot commented Jan 14, 2026

Jest Unit Test Results

    1 files  ±0    274 suites  ±0   5m 26s ⏱️ +7s
1 312 tests ±0  1 309 ✅ ±0  3 💤 ±0  0 ❌ ±0 
1 353 runs  ±0  1 350 ✅ ±0  3 💤 ±0  0 ❌ ±0 

Results for commit 3bf7e69. ± Comparison against base commit 01621df.

♻️ This comment has been updated with latest results.

@Dmytro-Melnyshyn Dmytro-Melnyshyn force-pushed the UIU-3506 branch 2 times, most recently from 173f65e to b8ec174 Compare January 14, 2026 11:00
@Dmytro-Melnyshyn Dmytro-Melnyshyn changed the title UIU-3506: Replace users/configurations/entry endpoint with users/settings/entries for profile picture config. UIU-3506: Replace users/configurations/entry endpoint with users/settings/entries for settings. Jan 14, 2026
@sonarqubecloud
Copy link

@Dmytro-Melnyshyn Dmytro-Melnyshyn requested review from a team and mukhiddin-yusuf January 14, 2026 12:40
@Dmytro-Melnyshyn Dmytro-Melnyshyn merged commit 1d1ce79 into master Jan 15, 2026
15 checks passed
@Dmytro-Melnyshyn Dmytro-Melnyshyn deleted the UIU-3506 branch January 15, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants