Wiping blue's from pngs with no transparency.#21
Open
Snkz wants to merge 3 commits intofoliojs:masterfrom
Open
Wiping blue's from pngs with no transparency.#21Snkz wants to merge 3 commits intofoliojs:masterfrom
Snkz wants to merge 3 commits intofoliojs:masterfrom
Conversation
Probably better to not use transparency length to determine ret array size but incase it was used for something I left it in there. It needs to be shifted when there is no transparency however, otherwise the blues get wiped from output png.
incase of 16bit channel values, keep transparency size equal to the channel size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probably better to not use transparency length to determine ret array size but incase it was used for something I left it in there.
It needs to be shifted when there is no transparency however, otherwise the blues get wiped from output png.