Open
Conversation
…he deploy.yml file
…remove_deploy.yml file
…nfiguration of the 'Set aks context' step
Owner
|
Hi @AmeyalliRosas ! Thank you for the PR! What is the goal for this PR? That is, what does the playbook ultimately allow you to do? I also saw there are some github actions workflows that are being added. How are those intended to be used? Could you help me understand all the changes being introduced? There are many commits being added here. It would be great to consolidate the commits to a smaller few for easier history tracking. Lastly, I think it's great to have an ansible playbook that we can use to deploy pacman. I'm wondering if it makes the most sense to add it directly to the pacman repo here, or in the k8s-example-apps repo https://github.com/font/k8s-example-apps, or in its own repo. Thoughts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the keys have to be modified