This repository was archived by the owner on Aug 10, 2020. It is now read-only.
Change how invoice email is done to an observer event#4
Open
ProxiBlue wants to merge 1 commit intofontis:masterfrom
Open
Change how invoice email is done to an observer event#4ProxiBlue wants to merge 1 commit intofontis:masterfrom
ProxiBlue wants to merge 1 commit intofontis:masterfrom
Conversation
chnorton
force-pushed
the
master
branch
2 times, most recently
from
d2b9632 to
509ade6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed how the order invoice emails are sent.
The current way using Fontis_EwayAu_Model_Direct::processInvoice is flawed.
Customers mistake the invoice email for the success email, as it is received first.
If something happens during the order process, (after this method is called) the client will receive an email with the invoice, which states an invoice id for them.
If (for some reason) the reserved invoice id is rolled back, you will find two clients with emails that have the same invoice id. (This has occurred on a site recently, which prompted this change)
The sending has been moved to an event that runs after the order objects have been successfully created and saved.
This then also negates the need to force save the invoice object (as per old code)