Skip to content

Conversation

@zjac0bs
Copy link
Member

@zjac0bs zjac0bs commented Jul 12, 2024

  • ENTSOE questions added
  • Some minor Google Cloud changes to account for larger question set (Gen1 --> Gen2)

@zjac0bs zjac0bs requested a review from houtanb July 12, 2024 13:04
@zjac0bs zjac0bs self-assigned this Jul 12, 2024
{"id": "61980", "station": "Roland Garros Airport"},
{"id": "61996", "station": "Amsterdam Island"},
{"id": "61997", "station": "Île de la Possession"},
{"id": "61998", "station": "Grande Terre"},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to think about removing series now that we're keeping things forever. If this is commit goes in before the survey, then OK to delete and I'll refetch everything. Otherwise, they're already in dfq and need to be handled differently. If they were already in the question set, they should never be deleted. If not, then we can delete and write code to remove from dfq

"country_name": "Slovakia",
},
{"country_source_id": "SK.B16.D", "energy_source": "solar", "country_name": "Slovakia"},
{"country_source_id": "SK.B20.D", "energy_source": "other", "country_name": "Slovakia"},
Copy link
Member

@houtanb houtanb Jul 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these "energy_source" values don't read well in the question. e.g. "other":

What is the probability that the actual daily electricity generated from other in Slovakia will be higher on the date of resolution listed below than on {forecast_due_date}?

Should "solar" be changed to "solar energy sources" to read more clearly? "nuclear" to "nuclear energy"? "hydro run-of-river and poundage" seems to be a typo at the data source and should be "pondage": https://en.wikipedia.org/wiki/Run-of-the-river_hydroelectricity and could be renamed "Run-of-the-river & pondage hydroelectricity", etc. for all the energy source types.



CONSTANTS = create_meteofrance_constants(METEOFRANCE_STATIONS)
CONSTANTS += create_entso_e_constants(ENTSO_E_GENERATION_SOURCES)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URLs are still incorrect, both for ENTSOE and meteofrance

VALUE_EXPLANATIONS = {
"meteofrance": "The daily average temperature at the French weather station at {station}."
"meteofrance": "The daily average temperature at the French weather station at {station}.",
"ENTSO_E": "The actual realised daily electricity generated from {energy_source} in {country_name}.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a unit here. $7$ as an amount of electricity doesn't quite make sense.

"freeze_datetime_value": 7.0,
"freeze_datetime_value_explanation": "The actual realised daily electricity generated from solar in Norway.",

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

realized instead of realised?

"at {station} will be higher on {resolution_date} than on {forecast_due_date}?"
)
),
"ENTSO_E": (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just "ENTSOE" (no underscore)? like in this URL: https://db.nomics.world/ENTSOE/AGPT/SK.B20.D?tab=chart

),
"ENTSO_E": (
"What is the probability that the actual daily electricity generated from {energy_source} in "
"{country_name} will be higher on the date of resolution listed below than on {forecast_due_date}?"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change "the date of resolution listed below" to {resolution_date}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants