Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new Command.allow_negative_expressions() mode to treat dash-prefixed mathematical expressions (and similar tokens) as positional arguments, expanding ArgMojo’s handling of “negative-looking” inputs beyond numeric literals.
Changes:
- Introduce
_allow_negative_expressionsflag +allow_negative_expressions()builder onCommand. - Add parsing logic to consume certain
-...tokens as positionals in bothparse_arguments()andparse_known_arguments(). - Add documentation and tests describing/validating the new behavior.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_parse.mojo | Adds test cases for negative-expression passthrough behavior. |
| src/argmojo/command.mojo | Implements the new command flag, parsing rules, and help-tip adjustments. |
| docs/user_manual.md | Documents the new approach and compares it to existing mechanisms. |
| docs/declarative_api_planning.md | Notes the feature as builder-only/imperative parser behavior. |
| docs/changelog.md | Adds an unreleased changelog entry for the new feature. |
| docs/argmojo_overall_planning.md | Updates the parsing algorithm planning notes to include the new rule. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new
Command.allow_negative_expressions()mode to treat dash-prefixed mathematical expressions (and similar tokens) as positional arguments, expanding ArgMojo’s handling of “negative-looking” inputs beyond numeric literals.Changes:
_allow_negative_expressionsflag +allow_negative_expressions()builder onCommand.-...tokens as positionals in bothparse_arguments()andparse_known_arguments().