Conversation
There was a problem hiding this comment.
Pull request overview
Fixes BigInt construction from 128-bit scalar integer types (Int128/UInt128) by updating the generic scalar conversion path and extending the conversion test suite accordingly.
Changes:
- Extend
test_from_integral_scalarto coverUInt128andInt128(including MIN/MAX). - Rework
BigInt.from_integral_scalarword-extraction logic to handle wider scalar types beyond 64-bit.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tests/bigint/test_bigint_conversion.mojo |
Adds coverage for UInt128/Int128 scalar-to-BigInt conversions (small/large, MIN/MAX). |
src/decimo/bigint/bigint.mojo |
Updates scalar conversion implementation to extract 32-bit limbs from wider scalar types. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Int128
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix broken conversion from Int128 and add proper support for all integral types (Int128, Int256, UInt128, UInt256, platform-sized Int/UInt).
The old code cast everything through UInt64, silently truncating wide integers. The Int.MIN special-case was also fragile.
Now from_integral_scalar dispatches per dtype at comptime:
Removed standalone from_uint64 and from_uint128 (folded into from_integral_scalar). Updated sqrt call sites accordingly.
Added tests for Int.MIN/MAX edge cases, Int128/Int256 MIN/MAX, UInt128.MAX, UInt256, platform-sized types, and zero across all types.