Conversation
There was a problem hiding this comment.
Pull request overview
Introduces initial scaffolding and documentation for optional MPFR/GMP integration, including a C shared-library wrapper (loaded via dlopen/dlsym) and Mojo-side FFI bindings intended to support a future MPFR-backed BigFloat type.
Changes:
- Added a C-based MPFR wrapper with lazy runtime loading plus a build script and pixi tasks to compile it.
- Added Mojo FFI bindings (
mpfr_wrapper.mojo) and a placeholderbigfloat.mojofor the upcomingBigFloatAPI. - Updated repository documentation/licensing notes (NOTICE + planning doc) and ignore rules for generated shared libraries.
Reviewed changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/decimo/gmp/README.md | Documents wrapper architecture, build, and runtime behavior. |
| src/decimo/gmp/gmp_wrapper.c | Adds C wrapper that lazily loads MPFR and exposes handle-based operations for Mojo FFI. |
| src/decimo/gmp/build_gmp_wrapper.sh | Builds the shared library for macOS/Linux. |
| src/decimo/bigfloat/mpfr_wrapper.mojo | Mojo FFI bindings to the C wrapper functions. |
| src/decimo/bigfloat/bigfloat.mojo | Placeholder module and precision helper for future BigFloat. |
| src/decimo/bigfloat/init.mojo | Adds package-level documentation for bigfloat. |
| README.md | Minor README content reflow + mention of CLI tool. |
| pixi.toml | Adds tasks to build the wrapper (buildgmp, bgmp). |
| NOTICE | Adds third-party notice for optional MPFR/GMP runtime usage. |
| docs/readme_unreleased.md | Updates badges/text and documents optional MPFR/GMP usage. |
| docs/plans/gmp_integration.md | Adds detailed GMP/MPFR integration plan. |
| .gitignore | Ignores built .dylib/.so artifacts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces initial scaffolding and documentation for optional MPFR/GMP integration, including a C shared-library wrapper (loaded via
dlopen/dlsym) and Mojo-side FFI bindings intended to support a future MPFR-backedBigFloattype.Changes:
mpfr_wrapper.mojo) and a placeholderbigfloat.mojofor the upcomingBigFloatAPI.