Conversation
There was a problem hiding this comment.
Pull request overview
Adds a detailed enhancement/audit plan for the src/decimo/decimal128/ module, capturing cross-language comparisons (C#, Rust, Arrow, Go), identified correctness gaps, performance bottlenecks, and a prioritized execution order.
Changes:
- Introduces a comprehensive design/audit document for
Decimal128, including a cross-language feature matrix. - Documents key architectural concerns (notably the 2^96−1 coefficient bound) and related performance implications.
- Lists suspected correctness/performance issues and proposes a phased implementation plan.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
forfudan
changed the title
Decimal128 typeDecimal128 type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a detailed enhancement/audit plan for the
decimo.decimal128module, capturing cross-language comparisons, identified correctness gaps, performance bottlenecks, and a prioritized execution order.Changes:
Decimal128, including a cross-language feature matrix.