Merged
Conversation
Contributor
WalkthroughThe token management flow in NewStackClient is refactored to use a refresh-aware token source. Instead of a one-shot fetch, NewStackTokenSource is now initialized with an onRefresh callback that automatically persists refreshed tokens via WriteStackToken, enabling dynamic token lifecycle management. Changes
Sequence Diagram(s)sequenceDiagram
actor Client
participant NewStackClient
participant NewStackTokenSource
participant oauth2 as oauth2.TokenSource
participant WriteStackToken
Client->>NewStackClient: Initialize
NewStackClient->>NewStackTokenSource: Create with stackToken, stackAccess, onRefresh callback
NewStackTokenSource-->>NewStackClient: Token Source ready
Client->>oauth2: Request token
oauth2->>NewStackTokenSource: Get token (may refresh)
alt Token expired
NewStackTokenSource->>NewStackTokenSource: Refresh token
NewStackTokenSource->>WriteStackToken: onRefresh(newToken)
WriteStackToken-->>NewStackTokenSource: Token persisted
end
NewStackTokenSource-->>oauth2: Return token
oauth2-->>Client: Token available
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
Dav-14
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.