Skip to content

fix(cloud): must login with scopes#112

Merged
Dav-14 merged 1 commit intomainfrom
fix/login_with_scopes
Feb 2, 2026
Merged

fix(cloud): must login with scopes#112
Dav-14 merged 1 commit intomainfrom
fix/login_with_scopes

Conversation

@Dav-14
Copy link
Contributor

@Dav-14 Dav-14 commented Feb 2, 2026

No description provided.

@Dav-14 Dav-14 requested a review from a team as a code owner February 2, 2026 11:09
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 2, 2026

Walkthrough

The NewAppDeployClient function in pkg/clients.go now specifies required OAuth scopes ("apps:Read" and "apps:Write") for the deployment client, replacing the previous empty scope list.

Changes

Cohort / File(s) Summary
Deployment Client Scopes
pkg/clients.go
Updated NewAppDeployClient to include "apps:Read" and "apps:Write" scopes instead of empty scope list, granting necessary app access permissions for deployment operations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Poem

🐰 With scopes expanded, the deploys take flight,
Read and write permissions shining so bright,
Apps now accessible, permissions aligned,
A little config change, but peace of mind!

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess whether the description relates to the changeset. Add a description explaining why the scopes are needed and what impact this change has on the deployment authentication flow.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix(cloud): must login with scopes' directly relates to the main change which updates the required scopes for the deployment app client.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/login_with_scopes

Comment @coderabbitai help to get the list of available commands and usage tips.

@Dav-14 Dav-14 enabled auto-merge (squash) February 2, 2026 11:09
@Dav-14 Dav-14 merged commit 8989ac4 into main Feb 2, 2026
4 checks passed
@Dav-14 Dav-14 deleted the fix/login_with_scopes branch February 2, 2026 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants