Skip to content

fix: output queue listener callback error as string#548

Merged
laouji merged 1 commit intomainfrom
fix/listener-log
Feb 5, 2026
Merged

fix: output queue listener callback error as string#548
laouji merged 1 commit intomainfrom
fix/listener-log

Conversation

@laouji
Copy link
Contributor

@laouji laouji commented Feb 5, 2026

No description provided.

@coderabbitai
Copy link

coderabbitai bot commented Feb 5, 2026

Walkthrough

Error logging in message processing was refactored from formatted output to structured logging. An "err" field was added to the error log to capture the error string. No changes to message acknowledgment behavior or control flow.

Changes

Cohort / File(s) Summary
Error Logging Refactoring
queue/listener.go
Replaced formatted error output with structured logging by adding an "err" field for error strings in message processing error logs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 Hop hop, error logs now shine bright,
Structured fields make debugging a delight,
No logic changed, just format refined,
Cleaner logs for peace of mind!

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to evaluate whether it relates to the changeset. Add a brief description explaining why the error logging format was changed and any benefits of using structured logging with an 'err' field.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix: output queue listener callback error as string' directly and specifically describes the main change: converting error logging in the queue listener callback to output the error as a string using structured logging.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/listener-log

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@laouji laouji marked this pull request as ready for review February 5, 2026 16:59
@laouji laouji requested a review from a team as a code owner February 5, 2026 16:59
@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 28.73%. Comparing base (8d136e6) to head (52a16fc).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
queue/listener.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #548      +/-   ##
==========================================
- Coverage   28.80%   28.73%   -0.08%     
==========================================
  Files         175      175              
  Lines        7062     7062              
==========================================
- Hits         2034     2029       -5     
- Misses       4911     4914       +3     
- Partials      117      119       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@laouji laouji added this pull request to the merge queue Feb 5, 2026
Merged via the queue into main with commit 28afbaf Feb 5, 2026
5 of 7 checks passed
@laouji laouji deleted the fix/listener-log branch February 5, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants