Skip to content

feat(regions): embed operator resource#303

Merged
Dav-14 merged 1 commit intomainfrom
feat/embed-operator-resource
Feb 9, 2026
Merged

feat(regions): embed operator resource#303
Dav-14 merged 1 commit intomainfrom
feat/embed-operator-resource

Conversation

@Dav-14
Copy link
Contributor

@Dav-14 Dav-14 commented Feb 9, 2026

No description provided.

@Dav-14 Dav-14 requested a review from a team as a code owner February 9, 2026 10:30
@coderabbitai
Copy link

coderabbitai bot commented Feb 9, 2026

Walkthrough

Version bump for the Regions chart from 3.6.9 to 3.7.0, with documentation updates reflecting new configuration options, dependency declarations, and expanded value definitions across chart metadata.

Changes

Cohort / File(s) Summary
Chart Version Reference
README.md
Updated Regions chart version entry from 3.6.9 to 3.7.0.
Chart Documentation & Configuration
charts/regions/README.md
Version badge bumped to 3.7.0. Added core dependency reference (file://../core, 1.X). Introduced new public configuration keys: global.serviceHost, fullnameOverride, nameOverride, stacks, and settings. Modified operator-crds.create defaults. Expanded Public Values section with updated configuration documentation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A chart hops up from old to new,
Version three-point-seven, fresh and true!
With configs declared and dependencies clear,
The Regions chart evolves this season's year! 📈✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive No description was provided by the author, making it impossible to assess relevance to the changeset. Add a pull request description explaining the purpose and impact of embedding operator resources in the regions chart.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: embedding operator resources in the regions chart, as evidenced by version bumps, new dependency references, and operator configuration additions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/embed-operator-resource

Comment @coderabbitai help to get the list of available commands and usage tips.

flemzord
flemzord previously approved these changes Feb 9, 2026
Base automatically changed from feat/EN-724-add-wizard-job to main February 9, 2026 10:56
@Dav-14 Dav-14 dismissed flemzord’s stale review February 9, 2026 10:56

The base branch was changed.

@Dav-14 Dav-14 force-pushed the feat/embed-operator-resource branch from 82d6200 to e07b201 Compare February 9, 2026 11:02
@Dav-14 Dav-14 enabled auto-merge (squash) February 9, 2026 11:02
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Fix all issues with AI agents
In `@charts/regions/README.md`:
- Line 87: Document the breaking default change for
operator.operator-crds.create in the README Migration section: add a Version
3.7.0 note explaining that operator.operator-crds.create now defaults to false,
why it changed (CRDs expected to be managed separately or embedded), and clear
upgrade guidance for users from 3.6.9 (set operator.operator-crds.create: true
to preserve old behavior, or install CRDs separately via kubectl apply -f
<crd-manifest-url>, and note that no action is needed if CRDs are already
installed); place this text near the existing Migration section (around the top
~25 lines) so users see it during upgrades.
- Line 67: Add user-facing descriptions for the new Helm chart configuration
keys so the README table explains their purpose: update the table entries for
global.serviceHost, fullnameOverride, nameOverride, settings, and stacks to
include concise descriptions (e.g., what each key controls, expected value
types, defaults and examples) and ensure the text matches the chart's behavior
(values.yaml/templating for these keys such as fullnameOverride and nameOverride
and how settings/stacks are applied). Locate the entries by the exact key names
(global.serviceHost, fullnameOverride, nameOverride, settings, stacks) and
replace the empty description column with brief, accurate descriptions and
example usage.
🧹 Nitpick comments (1)
charts/regions/README.md (1)

11-11: Document the new core dependency.

The core chart dependency (version 1.X) was added without explanation. Users need to understand what this dependency provides and why it's required for the Regions chart.

📝 Suggested documentation improvement

Consider adding a section after the Requirements table that explains the purpose of the core dependency:

## Requirements

| Repository | Name | Version |
|------------|------|---------|
| file://../agent | agent | 2.X |
| file://../core | core | 1.X |
| oci://ghcr.io/formancehq/helm | operator | 3.X |

### Dependency Notes

- **core**: Provides shared library chart with common templates and helpers used across Formance charts
- **agent**: Formance Membership Agent for region management
- **operator**: Formance Kubernetes operator for stack lifecycle management

@Dav-14 Dav-14 merged commit 9b4b14c into main Feb 9, 2026
5 checks passed
@Dav-14 Dav-14 deleted the feat/embed-operator-resource branch February 9, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants