Skip to content

chore: add mailmap to clean git shortlog#1188

Open
sylr wants to merge 1 commit intomainfrom
chore/mailmap
Open

chore: add mailmap to clean git shortlog#1188
sylr wants to merge 1 commit intomainfrom
chore/mailmap

Conversation

@sylr
Copy link
Contributor

@sylr sylr commented Dec 16, 2025

Summary by cubic

Add a .mailmap to unify contributor emails and produce a clean git shortlog.

Written for commit b5dbcac. Summary will update automatically on new commits.

@sylr sylr requested a review from a team as a code owner December 16, 2025 10:37
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 16, 2025

Walkthrough

A new .mailmap file was added containing 13 name/email mapping entries that consolidate contributor identity references across various email addresses for canonical name resolution.

Changes

Cohort / File(s) Summary
Configuration metadata
\.mailmap
Added 13 contributor name/email mappings for identity consolidation

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Verify that all name/email pairs are accurate and complete
  • Confirm mappings correspond to actual project contributors

Poem

🐰 A map of names, both old and new,
Email trails that contributors pursue,
Identity woven in lines so neat,
Making contributor histories complete!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: add mailmap to clean git shortlog' directly and clearly describes the main change: adding a .mailmap file to improve git shortlog output.
Description check ✅ Passed The description is directly related to the changeset, explaining the purpose of adding a .mailmap file to unify contributor emails and produce a clean git shortlog.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/mailmap

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between fd1883d and b5dbcac.

📒 Files selected for processing (1)
  • .mailmap (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Tests
  • GitHub Check: Dirty
🔇 Additional comments (2)
.mailmap (2)

1-1: Clarify PR scope discrepancy.

The PR description mentions "test/performance/pkg/write/export fixture" in addition to the .mailmap file, but only the .mailmap is provided for review. Please confirm whether the test fixtures are included in this PR or if the description was auto-generated incorrectly.


1-13: .mailmap file is syntactically valid but incomplete—missing several active contributors.

While the file syntax is correct and the 13 entries follow standard .mailmap format, the coverage is insufficient. Git history shows 20+ unique contributors, but several with substantial commits are missing:

  • Paul Nicolas (68 commits)
  • Igor Dreher
  • Antoine Gelloz (16 commits)
  • Alexandre Gourdel
  • Rohan Gupta
  • dependabot[bot] (17 commits)
  • ascandone (7 commits)

Additionally, "Geoffrey Ragot" appears in history as both "Ragot Geoffrey" (370 commits) and "Geoffrey Ragot" (358 commits)—verify the .mailmap entry consolidates both variants correctly. The "RAGOT David" format in history should also be checked against the "David Ragot" entry.

Add missing contributors and verify existing entries map all name/email variants in the commit history.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: Sylvain Rabot <sylvain@formance.com>
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.58%. Comparing base (fd1883d) to head (b5dbcac).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1188      +/-   ##
==========================================
+ Coverage   76.50%   76.58%   +0.07%     
==========================================
  Files         197      197              
  Lines       10274    10274              
==========================================
+ Hits         7860     7868       +8     
+ Misses       1447     1442       -5     
+ Partials      967      964       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant