Skip to content

fix: rename otel timestamp attribute#1246

Open
sylr wants to merge 1 commit intomainfrom
fix/otel-attribute
Open

fix: rename otel timestamp attribute#1246
sylr wants to merge 1 commit intomainfrom
fix/otel-attribute

Conversation

@sylr
Copy link
Contributor

@sylr sylr commented Feb 3, 2026

This attribute is standardize and setting it with a string messes with signoz.

@sylr sylr requested a review from a team as a code owner February 3, 2026 10:27
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 3, 2026

Walkthrough

Tracing attributes in InsertTransaction (ledger) were renamed and extended: "id" → "transaction.id", "timestamp" → "transaction.timestamp", and a new "transaction.reference" attribute was added. No control flow, error handling, or public API signatures were changed.

Changes

Cohort / File(s) Summary
Ledger Transaction Tracing
internal/storage/ledger/transactions.go
Updated tracing attributes in InsertTransaction: renamed "id""transaction.id", renamed "timestamp""transaction.timestamp", and added "transaction.reference" containing tx.Reference. Only observability metadata changed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 a rabbit scribbles in the logbook

I hopped through code to tweak a name,
id and time now wear new fame,
a reference added, neat and slight,
ledger traces gleam in clearer light. 🥕✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: renaming an OpenTelemetry timestamp attribute in the tracing code.
Description check ✅ Passed The description explains the reason for the change (standardized attribute causing issues with SigNoz) and relates to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/otel-attribute

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

gfyrag
gfyrag previously approved these changes Feb 3, 2026
@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.21%. Comparing base (a2b701e) to head (999cc3f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1246   +/-   ##
=======================================
  Coverage   82.20%   82.21%           
=======================================
  Files         198      198           
  Lines       10224    10225    +1     
=======================================
+ Hits         8405     8406    +1     
+ Misses       1326     1325    -1     
- Partials      493      494    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This attribute is standardize and setting it with a string messes with signoz.

Signed-off-by: Sylvain Rabot <sylvain@formance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants