Skip to content

fix: rename otel timestamp attribute#1247

Open
sylr wants to merge 1 commit intorelease/v2.3from
hotfix/v2.3/fix-otel-attribute
Open

fix: rename otel timestamp attribute#1247
sylr wants to merge 1 commit intorelease/v2.3from
hotfix/v2.3/fix-otel-attribute

Conversation

@sylr
Copy link
Contributor

@sylr sylr commented Feb 3, 2026

This attribute is standardize and setting it with a string messes with signoz.

@sylr sylr requested a review from a team as a code owner February 3, 2026 10:33
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 3, 2026

Walkthrough

The pull request updates tracing in the transaction storage insertion: attribute keys were renamed to a namespaced form and a new transaction.reference attribute was added; imports were reorganized with no behavioral change.

Changes

Cohort / File(s) Summary
Transaction tracing & imports
internal/storage/ledger/transactions.go
In InsertTransaction tracing callback: renamed idtransaction.id and timestamptransaction.timestamp; added transaction.reference set to tx.Reference. Imports were regrouped (no semantic change).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐇 I nibble bytes and trace the flow,
Transaction keys now tidy — watch them glow,
A new little reference hops into sight,
Logs shine clearer in the moonlight. ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix: rename otel timestamp attribute' directly describes the main change - renaming an OpenTelemetry timestamp attribute from 'timestamp' to 'transaction.timestamp' as shown in the summary.
Description check ✅ Passed The description explains the context and rationale for the change - that the attribute is standardized and using a string caused issues with SigNoz, which aligns with the code changes made to rename the otel attribute.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch hotfix/v2.3/fix-otel-attribute

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

This attribute is standardize and setting it with a string messes with signoz.

Signed-off-by: Sylvain Rabot <sylvain@formance.com>
@sylr sylr force-pushed the hotfix/v2.3/fix-otel-attribute branch from 115ba0f to d6e5753 Compare February 3, 2026 10:39
@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.78%. Comparing base (42bbfb5) to head (d6e5753).

Additional details and impacted files
@@              Coverage Diff              @@
##           release/v2.3    #1247   +/-   ##
=============================================
  Coverage         81.78%   81.78%           
=============================================
  Files               187      187           
  Lines              9059     9060    +1     
=============================================
+ Hits               7409     7410    +1     
+ Misses             1215     1212    -3     
- Partials            435      438    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants