Conversation
|
Warning Rate limit exceeded@BrieucCaillot has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 2 minutes and 42 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughA new README.md file is added documenting the Formance Wallets project. The file includes a banner image, project description, and a bulleted feature list covering multi-currency balances, temporary holds, reserved funds, and expirable fungibles. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (2 inconclusive)
✅ Passed checks (1 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
README.md (1)
2-2: Improve image alt text for better accessibility and context.The alt text
"wallets"is generic. Consider a more descriptive phrase like"Formance Wallets service overview banner"to better describe the image content for screen readers.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
README.md(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Tests
🔇 Additional comments (1)
README.md (1)
1-3: URL is currently accessible; consider long-term availability strategy.The banner image URL currently responds with HTTP 200. However, external CDN-hosted assets carry inherent risks—the URL could become unavailable if the CDN changes, the account is deleted, or the file is moved. Consider whether hosting the banner directly in the repository (e.g., in a
docs/images/directory) better aligns with your project's long-term maintenance strategy.
|
|
||
| # Formance Wallets | ||
|
|
||
| Wallets is a fully managed, white-label wallet service to materialize and spend users funds. It comes with built-in support for multi-currency balances and temporary holds capabilities (and upcoming support for reserved funds and expirable fungibles). It is built on top of the Formance Ledger service and is designed to provide an easy way to add wallets capabilities to your application without having to worry about the underlying transactions structure, providing an opinionated model implementation. |
There was a problem hiding this comment.
Resolve inconsistency between description and feature list regarding "Reserved funds" and "Expirable fungibles".
The description (line 7) states these are "upcoming support," but the features list (lines 11-14) presents them as current features. Please clarify:
- If they are currently available, remove "upcoming support" from the description.
- If they are planned but not yet implemented, remove them from the feature list or explicitly label them as "Coming soon."
Also applies to: 11-14
🤖 Prompt for AI Agents
In README.md around lines 7 and 11-14, the intro says "upcoming support" for
"reserved funds" and "expirable fungibles" while the feature list currently
presents them as available; choose one of the two: either remove "upcoming
support" from line 7 if those features are already implemented, or mark the two
items in the feature list (lines 11-14) as "Coming soon" or remove them if not
implemented. Update the text so the description and feature list consistently
reflect the current implementation status.
43daa49 to
d5bbdf6
Compare
d5bbdf6 to
16f4abf
Compare
No description provided.