Pivoting QR decomposition #1045

loiseaujc · 2025-10-20T12:50:06Z

Following #930, this PR extends the qr interface to enable the computation of the QR factorization with column pivoting. It is based on the xGEQP3 driver from lapack.

Proposed interfaces

call qr(a, q, r, pivots [, overwrite_a, storage, err])

where a is the matrix to be factorized, q the orthonormal basis for colspan(a), r the upper triangular matrix and pivots an integer array with indices of the pivoted columns.

Progress

Ping: @perazz, @jvdp1, @jalvesz

loiseaujc · 2025-10-22T10:18:01Z

I think this PR is almost ready to be reviewed. I have the specs left to write but this should pretty quick as it mainly is a small modification of the qr specs. I'll try to do that by the end of the week. It seems like there is a small issue with the unbuntu-22.04/cmake/inter-classic 2021.10 setup though. Not sure what it is and I don't have the intel compilers on my laptop so I can't really dig into it at the moment.

Copilot

Pull Request Overview

This PR adds support for QR factorization with column pivoting to the linear algebra library. The implementation leverages the LAPACK geqp3 routine and extends the existing qr interface to support pivot tracking.

Adds pivoting QR factorization via geqp3 LAPACK routine
Extends qr() and qr_space() interfaces to support column pivoting with pivot output
Includes comprehensive test coverage for tall, wide, and rank-deficient matrices

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
test/linalg/test_linalg_pivoting_qr.fypp	Comprehensive test suite for pivoting QR factorization across different matrix types and configurations
test/linalg/CMakeLists.txt	Adds pivoting QR test to build system
src/stdlib_linalg_qr.fypp	Implements pivoting QR factorization routines and workspace calculation
src/stdlib_linalg_lapack.fypp	Adds LAPACK `geqp3` interface for QR with column pivoting
src/stdlib_linalg.fypp	Extends public interface with pivoting QR subroutines
src/lapack/stdlib_linalg_lapack_aux.fypp	Adds error handler for `geqp3` LAPACK routine
example/linalg/example_pivoting_qr_space.f90	Example demonstrating pivoting QR with pre-allocated storage
example/linalg/example_pivoting_qr.f90	Basic example demonstrating pivoting QR factorization
example/linalg/CMakeLists.txt	Adds pivoting QR examples to build system

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

test/linalg/test_linalg_pivoting_qr.fypp

src/stdlib_linalg_lapack.fypp

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

codecov · 2025-11-04T14:53:12Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@9e4c230). Learn more about missing BASE report.

Additional details and impacted files

@@            Coverage Diff            @@
##             master    #1045   +/-   ##
=========================================
  Coverage          ?   25.12%           
=========================================
  Files             ?      570           
  Lines             ?   234201           
  Branches          ?    41275           
=========================================
  Hits              ?    58845           
  Misses            ?   175356           
  Partials          ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

loiseaujc · 2025-11-05T09:00:59Z

Modulo the issue with the unbuntu-22.04/cmake/intel-classic 2021.10 setup which I haven't been able to investigate yet, this PR is ready for review.

doc/specs/stdlib_linalg.md

jvdp1

Thank you @loiseaujc . Overall LGTM. I just have some minor suggestions.

doc/specs/stdlib_linalg.md

jvdp1 · 2025-11-08T13:57:07Z

src/stdlib_linalg_lapack.fypp

+            pure subroutine sgeqp3(m, n, a, lda, jpvt, tau, work, lwork, info)
+                import sp, dp, qp, ${ik}$, lk
+                implicit none
+                integer(${ik}$), intent(in) :: m, n, lda, lwork
+                integer(${ik}$), intent(out) :: info
+                integer(${ik}$), intent(inout) :: jpvt(*)
+                real(sp), intent(inout) :: a(lda, *)
+                real(sp), intent(out) :: tau(*), work(*)
+            end subroutine sgeqp3
+
+            pure subroutine dgeqp3(m, n, a, lda, jpvt, tau, work, lwork, info)
+                import sp, dp, qp, ${ik}$, lk
+                implicit none
+                integer(${ik}$), intent(in) :: m, n, lda, lwork
+                integer(${ik}$), intent(out) :: info
+                integer(${ik}$), intent(inout) :: jpvt(*)
+                real(dp), intent(inout) :: a(lda, *)
+                real(dp), intent(out) :: tau(*), work(*)
+            end subroutine dgeqp3
+
+            pure subroutine cgeqp3(m, n, a, lda, jpvt, tau, work, lwork, rwork, info)
+                import sp, dp, qp, ${ik}$, lk
+                implicit none
+                integer(${ik}$), intent(in) :: m, n, lda, lwork
+                integer(${ik}$), intent(out) :: info
+                integer(${ik}$), intent(inout) :: jpvt(*)
+                complex(sp), intent(inout) :: a(lda, *)
+                complex(sp), intent(out) :: tau(*), work(*)
+                real(sp), intent(out) :: rwork(*)
+            end subroutine cgeqp3
+
+            pure subroutine zgeqp3(m, n, a, lda, jpvt, tau, work, lwork, rwork, info)
+                import sp, dp, qp, ${ik}$, lk
+                implicit none
+                integer(${ik}$), intent(in) :: m, n, lda, lwork
+                integer(${ik}$), intent(out) :: info
+                integer(${ik}$), intent(inout) :: jpvt(*)
+                complex(dp), intent(inout) :: a(lda, *)
+                complex(dp), intent(out) :: tau(*), work(*)
+                real(dp), intent(out) :: rwork(*)
+            end subroutine zgeqp3


It seems that all of these interfaces could be defined using a fypp pre-processing approach.

Yeah sure. I copied what looked like the standard way to do it in the stdlib_linalg_lapack.fypp file, eg.

#:for ik,it,ii in LINALG_INT_KINDS_TYPES #ifdef STDLIB_EXTERNAL_LAPACK${ii}$ pure recursive subroutine cgeqrt3( m, n, a, lda, t, ldt, info ) import sp,dp,qp,${ik}$,lk implicit none integer(${ik}$), intent(out) :: info integer(${ik}$), intent(in) :: lda,m,n,ldt complex(sp), intent(inout) :: a(lda,*) complex(sp), intent(out) :: t(ldt,*) end subroutine cgeqrt3 #else module procedure stdlib${ii}$_cgeqrt3 #endif #ifdef STDLIB_EXTERNAL_LAPACK${ii}$ pure recursive subroutine dgeqrt3( m, n, a, lda, t, ldt, info ) import sp,dp,qp,${ik}$,lk implicit none integer(${ik}$), intent(out) :: info integer(${ik}$), intent(in) :: lda,m,n,ldt real(dp), intent(inout) :: a(lda,*) real(dp), intent(out) :: t(ldt,*) end subroutine dgeqrt3 #else module procedure stdlib${ii}$_dgeqrt3 #endif ...

but simply lumped everything into a single #ifdef block. Are there any technical reasons why you guys went this way initially rather than fypp-ified the whole prefix thing ?

jvdp1 · 2025-11-08T14:02:41Z

test/linalg/test_linalg_pivoting_qr.fypp

+        !-------------------------------
+        !-----     Tall matrix     -----
+        !-------------------------------
+        block


I suggest that each block has its own subroutine. I would facilitate the review and maintainance IMHO.

Will do right away.

perazz

Thank you for this implementation @loiseaujc, great work.
I stand by @jvdp1's comments, and I added a few edits/typos.

Overall, looks good to me with the above.

src/lapack/stdlib_linalg_lapack_aux.fypp

src/stdlib_linalg.fypp

src/stdlib_linalg_qr.fypp

example/linalg/example_pivoting_qr_space.f90

Co-authored-by: Federico Perini <federico.perini@gmail.com>

Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>

Co-authored-by: Federico Perini <federico.perini@gmail.com>

loiseaujc added 9 commits October 20, 2025 14:17

Function interface for pivoting QR.

98f1708

Added interfaces for xGEQP3.

4b05928

Fix typos in geqp3 interface definition.

0c99ca1

Added handle info function for geqp3.

19cc0f0

Full implementation of pivoting QR.

55bc413

Added test for pivoting QR.

dd9b022

Added test for a tall matrix with rank deficiency.

bd80504

Added example for pivoting QR.

dd785a1

Added pivoting_qr_space example.

e72d2f4

loiseaujc linked an issue Oct 22, 2025 that may be closed by this pull request

Rank-revealing QR decomposition #930

Open

jalvesz requested a review from Copilot November 1, 2025 19:58

Copilot AI reviewed Nov 1, 2025

View reviewed changes

loiseaujc and others added 3 commits November 4, 2025 15:14

Update test/linalg/test_linalg_pivoting_qr.fypp

bf328f6

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update test/linalg/test_linalg_pivoting_qr.fypp

7454ecd

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update test/linalg/test_linalg_pivoting_qr.fypp

07efc4a

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

loiseaujc added 2 commits November 4, 2025 17:18

Clarify that GEQP3 works both for real and complex matrices.

2bb062a

Added specs.

e2eac02

loiseaujc marked this pull request as ready for review November 5, 2025 09:00

perazz reviewed Nov 5, 2025

View reviewed changes

doc/specs/stdlib_linalg.md Show resolved Hide resolved

jvdp1 approved these changes Nov 8, 2025

View reviewed changes

perazz approved these changes Nov 9, 2025

View reviewed changes

loiseaujc and others added 6 commits November 9, 2025 18:31

Update src/lapack/stdlib_linalg_lapack_aux.fypp

b1f1ad0

Co-authored-by: Federico Perini <federico.perini@gmail.com>

Update src/lapack/stdlib_linalg_lapack_aux.fypp

5535e3f

Co-authored-by: Federico Perini <federico.perini@gmail.com>

Update example/linalg/example_pivoting_qr_space.f90

b20a054

Co-authored-by: Federico Perini <federico.perini@gmail.com>

Update doc/specs/stdlib_linalg.md

dffc657

Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>

Update doc/specs/stdlib_linalg.md

05ae3f6

Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>

Update src/stdlib_linalg.fypp

43d6552

Co-authored-by: Federico Perini <federico.perini@gmail.com>

Apply suggestions from code review

81f2a4f

Co-authored-by: Federico Perini <federico.perini@gmail.com>

Pivoting QR decomposition #1045

Are you sure you want to change the base?

Pivoting QR decomposition #1045

Uh oh!

Conversation

loiseaujc commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed interfaces

Progress

Uh oh!

loiseaujc commented Oct 22, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

loiseaujc commented Nov 5, 2025

Uh oh!

Uh oh!

jvdp1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jvdp1 Nov 8, 2025

Choose a reason for hiding this comment

Uh oh!

loiseaujc Nov 9, 2025

Choose a reason for hiding this comment

Uh oh!

jvdp1 Nov 8, 2025

Choose a reason for hiding this comment

Uh oh!

loiseaujc Nov 9, 2025

Choose a reason for hiding this comment

Uh oh!

perazz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

loiseaujc commented Oct 20, 2025 •

edited

Loading

codecov bot commented Nov 4, 2025 •

edited

Loading