-
Notifications
You must be signed in to change notification settings - Fork 817
feat: create gif files and store them in a simple markdown file #3002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: flutter
Are you sure you want to change the base?
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds a new documentation markdown file that catalogs GIF assets used in experiment demonstration screens, linking directly to their image paths. Flow diagram for gif documentation markdown linking to assetsflowchart TD
DocsMarkdown[gif_files_md]
AssetsFolder[assets_images]
DocsMarkdown --> BarometerExperiment1_gif
DocsMarkdown --> BarometerExperiment2_gif
DocsMarkdown --> BarometerExperiment3_gif
DocsMarkdown --> Channel_parameters_gif
DocsMarkdown --> LightDistance1_gif
DocsMarkdown --> LightDistance2_gif
DocsMarkdown --> LightDistance3_gif
AssetsFolder --> BarometerExperiment1_gif
AssetsFolder --> BarometerExperiment2_gif
AssetsFolder --> BarometerExperiment3_gif
AssetsFolder --> Channel_parameters_gif
AssetsFolder --> LightDistance1_gif
AssetsFolder --> LightDistance2_gif
AssetsFolder --> LightDistance3_gif
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- Consider using consistent heading levels (e.g., start with
##for the main title instead of###) so the markdown structure is logically nested and renders as expected in different viewers. - Replace the generic
alt textplaceholders with descriptive alt text for each GIF to improve accessibility and make the file more self-explanatory. - Standardize section and file naming (e.g.,
BarometerExperimentvsLightDistance Experiment) so experiment names follow a consistent spacing/capitalization convention.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider using consistent heading levels (e.g., start with `##` for the main title instead of `###`) so the markdown structure is logically nested and renders as expected in different viewers.
- Replace the generic `alt text` placeholders with descriptive alt text for each GIF to improve accessibility and make the file more self-explanatory.
- Standardize section and file naming (e.g., `BarometerExperiment` vs `LightDistance Experiment`) so experiment names follow a consistent spacing/capitalization convention.
## Individual Comments
### Comment 1
<location> `docs/gif_files.md:4-13` </location>
<code_context>
+### gif files used in the experiment demonstration guide screen
+
+## BarometerExperiment
+
+
+
+
+## Channel parameters
+
+
+## LightDistance Experiment
+
+
+
+
</code_context>
<issue_to_address>
**suggestion:** Use descriptive alt text for images instead of the generic placeholder "alt text".
The current `` placeholders don’t provide useful information to screen readers or users if the GIFs fail to load. Replace them with short, specific descriptions of each GIF’s content (e.g., "Barometer experiment – step 1" or "Channel parameters screen").
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|  | ||
|  | ||
|  | ||
|
|
||
| ## Channel parameters | ||
|  | ||
|
|
||
| ## LightDistance Experiment | ||
|  | ||
|  |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Use descriptive alt text for images instead of the generic placeholder "alt text".
The current  placeholders don’t provide useful information to screen readers or users if the GIFs fail to load. Replace them with short, specific descriptions of each GIF’s content (e.g., "Barometer experiment – step 1" or "Channel parameters screen").
Fixes #2875.
Changes
I've created a markdown file(.md) which stores all the gif files used in experiment demonstration.
Screenshots / Recordings
N/A
Checklist:
constants.dartor localization files instead of hard-coded values.dart formator the IDE formatter.flutter analyzeand tests run influtter test.Summary by Sourcery
Documentation: