Open
Conversation
This commit introduces a new syntax for initializing structs directly
upon declaration, e.g., `var v: Vec = Vec{x:1, y:2};`.
Key changes:
- Updated grammar (`xlang/grammar.lark`) to parse the new syntax.
- Added `StructInitializer` and `StructInitializerMember` AST nodes
in `xlang/xl_ast.py`.
- Modified `ASTTransformer` (`xlang/transformer.py`) to correctly
construct these AST nodes, including a fix for collecting all
members when multiple are present.
- Updated `Interpreter` (`xlang/interpreter.py`) to handle the
`StructInitializer` node, correctly assigning provided values and
falling back to defaults.
- Enhanced `ValidationPass` (`xlang/validation_pass.py`) to validate
`StructInitializer` nodes, ensuring:
- Correct types for initialized members.
- All members without struct-defined defaults are initialized.
- Added comprehensive lit tests for the new syntax in
`tests/lit/structs.xl`, covering various initialization scenarios,
default value handling, and member order.
- Fixed minor parsing issues in test struct definitions by ensuring
all members end with a comma as required by the grammar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a new syntax for initializing structs directly upon declaration, e.g.,
var v: Vec = Vec{x:1, y:2};.Key changes:
xlang/grammar.lark) to parse the new syntax.StructInitializerandStructInitializerMemberAST nodes inxlang/xl_ast.py.ASTTransformer(xlang/transformer.py) to correctly construct these AST nodes, including a fix for collecting all members when multiple are present.Interpreter(xlang/interpreter.py) to handle theStructInitializernode, correctly assigning provided values and falling back to defaults.ValidationPass(xlang/validation_pass.py) to validateStructInitializernodes, ensuring:tests/lit/structs.xl, covering various initialization scenarios, default value handling, and member order.