Skip to content

Conversation

@quaresmajose
Copy link
Member

@quaresmajose quaresmajose commented Apr 7, 2025

With [1] we replace the bitbake bbclass image-license-checker and lmp-disable-gplv3 bbclass
with the lmp-no-gplv3 bbclass which also includes definitions implemented in oe-core.

The IMAGE_LICENSE_CHECKER_* is not need anymore and the control is made now with the
variable IMAGE_INCOMPATIBLE_LICENSE.

[1] foundriesio/meta-lmp#1618

@quaresmajose quaresmajose requested a review from a team April 7, 2025 14:54
@quaresmajose quaresmajose marked this pull request as draft April 8, 2025 10:19
@quaresmajose quaresmajose self-assigned this Apr 8, 2025
@quaresmajose quaresmajose marked this pull request as ready for review May 9, 2025 10:54
@angolini
Copy link
Contributor

Please update title and description. I'm not sure is helpful to mention v95 here

lmp/bb-config.sh Outdated

if [ "${DISABLE_GPLV3}" = "1" ]; then
cat << EOFEOF >> conf/local.conf
# supported in v95
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have to double check it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to change this comment to v96

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ended up not mentioning the version

@quaresmajose quaresmajose changed the title lmp/bb-config: add v95 no-gplv3 config lmp/bb-config: add support to the new lmp no-gplv3 config Jun 24, 2025
@angolini angolini requested a review from a team October 28, 2025 16:20
With [1] we replace the bitbake bbclass image-license-checker and lmp-disable-gplv3 bbclass
with the lmp-no-gplv3 bbclass which also includes definitions implemented in oe-core.

The IMAGE_LICENSE_CHECKER_* is not need anymore and the control is made now with the
variable IMAGE_INCOMPATIBLE_LICENSE.

[1] foundriesio/meta-lmp#1618

Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io>
@ricardosalveti
Copy link
Member

We can merged on monday, don't want to potentially break anything today :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants