lmp/build-sdk-container: override the latest tag via an environment variable #382
Conversation
|
The main intention of this PR is to add the possibility to build |
|
|
||
| container="hub.foundries.io/lmp-sdk" | ||
| tagged="${container}:${TAG}" | ||
| latest="${container}:latest" |
There was a problem hiding this comment.
I think you'll wind up needing a block like:
https://github.com/foundriesio/ci-scripts/blob/master/lmp/jobserv.yml#L18-L24
for changes to the "next" branch. Seems like the easiest way to control that will be via an environment variable. e.g.
- name: lmp-sdk-next
host-tag: amd64
container: foundries/dind-ci:19.03.9_b38f166
privileged: true
params:
LATEST=next
script-repo:
name: fio
path: lmp/build-sdk-container.sh
And then you could have this script take a variable for "latest". e.g:
LATEST=${LATEST:latest}
``
There was a problem hiding this comment.
Well! With the argument it wouldn't work. thanks for the tip.
Also added the block on the main build job:
- name: lmp-sdk-next
host-tag: amd64
container: foundries/dind-ci:19.03.9_b38f166
privileged: true
params:
LATEST=next
script-repo:
name: fio
path: lmp/build-sdk-container.sh
…ariable If the environment variable is present, use it as a tag when creating the container. The default is build with the tag latest and also with the corresponding version tag. Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io>
quaresmajose
force-pushed
the
build-sdk-container
branch
from
3efadd7 to
406defe
Compare
quaresmajose
changed the title
Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io>
quaresmajose
force-pushed
the
build-sdk-container
branch
from
406defe to
f74fe0d
Compare
doanac
left a comment
doanac
left a comment
There was a problem hiding this comment.
nice. we've wanted something like this for a long time
|
is this something we need to document (in the docs)? |
4 participants
If the environment variable is present, use it as a tag when creating the container.
The default is build with the tag latest and also with the corresponding version tag.