reg_client: Normalize dockerhub hostname for auth #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a given reference refers to an image hosted in the dockerhub, then the reference hostname must be normalized to the full dockerhub hostname URL before searching auth material in the config file since `docker login docker.io` sets a record for `https://index.docker.io/v1/` in the docker's config file. Signed-off-by: Mike Sul <mike.sul@foundries.io>
Contributor
Author
|
@doanac This PR is required to make this change in ci-scripts foundriesio/ci-scripts#405 work for images store in the dockerhub. |
Contributor
Author
|
I've forgotten that I moved the ci-scripts to |
doanac
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a given reference refers to an image hosted in the dockerhub, then the reference hostname must be normalized to the full dockerhub hostname URL before searching auth material in the config file since
docker login docker.iosets a record forhttps://index.docker.io/v1/in the docker's config file.