-
Notifications
You must be signed in to change notification settings - Fork 4
WIP: provider: Introduce support for satellite server #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
corresponding aklite code: |
mike-sul
reviewed
Nov 6, 2025
Collaborator
|
@doanac The direction seems reasonable to me. |
b1f6a0e to
ac362bd
Compare
mike-sul
reviewed
Nov 7, 2025
mike-sul
reviewed
Nov 7, 2025
mike-sul
reviewed
Nov 7, 2025
ac362bd to
795a754
Compare
The satellite server, https://github.com/foundriesio/dg-satellite, needs a way for devices to pick up registry content from it instead of hub.foundries.io. This change introduces a mechanism to tell our provider code to proxy its requests through the satellite server. The error handling in this is a little awkward but allowed us to bubble up errors w/o having to adjust a lot of users of the API. Signed-off-by: Andy Doan <andy@foundries.io>
795a754 to
007dc4b
Compare
mike-sul
reviewed
Nov 17, 2025
mike-sul
reviewed
Nov 17, 2025
Collaborator
|
LGTM, it works for me against the latest dg-sat. |
mike-sul
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The satellite server, https://github.com/foundriesio/dg-satellite, needs a way for devices to pick up registry content from it instead of hub.foundries.io. This change introduces a mechanism to tell our provider code to proxy its requests through the satellite server.
The error handling in this is a little awkward but allowed us to bubble up errors w/o having to adjust a lot of users of the API.