image_loader: Skip warning if expected index to exceed the max #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases it is expected that the image index becomes higher than the maximum allowed index. In particular, when the last image is loaded or when the last image is already present in the docker store. The only case when this is a real error is if a client starts receiving messages about loading a new image while the image index is already equal to an overall image count. Signed-off-by: Mike Sul <mike.sul@foundries.io>
Collaborator
Author
|
@detsch We need this to avoid printing the warning message when it is not relevant during app images loading to the docker store. |
detsch
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases it is expected that the image index becomes higher than the maximum allowed index. In particular, when the last image is loaded or when the last image is already present in the docker store. The only case when this is a real error is if a client starts receiving messages about loading a new image while the image index is already equal to an overall image count.