-
Notifications
You must be signed in to change notification settings - Fork 28
Updated QEMU CLI #850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated QEMU CLI #850
Conversation
source/user-guide/qemu/arm64.rst
Outdated
| -device virtio-net-device,netdev=net0,mac=52:54:00:12:35:02 \ | ||
| -device virtio-serial-device \ | ||
| -drive id=disk0,file=lmp-factory-image-qemuarm64-secureboot.wic,if=none,format=raw \ | ||
| -drive id=disk0,file=lmp-base-console-image-qemuarm64-secureboot.wic,if=none,format=raw \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can be dropped
lmp-factory-image is the image built from a factory
lmp-base-console-image is the initial build on a new factory
this is covered by a note in this page
|
@mmaddala as good practices, please also update the commit title and add a little bit of explanation on why this change is needed |
|
Updated the changes as suggested. Please look into them and let me know. |
|
@mmaddala That looks neat. I forgot about another best practice: keep your commit line up to 80 characters. |
|
@vanmaegima Thanks for letting me know. I have changed the commit line up to 80 characters. |
|
@mmaddala thanks Manjusha! I do notice some typos in the new commit title, if you can fix that I will approve it. |
|
@vanmaegima fixed the typos in the new commit line. |
|
@mmaddala the typo is still there: "for CLI command..." |
Running the QEMU CLI command from the document was opening a QEMU terminal, which should not happen. This was caused by a missing '\' that broke the command. The missing character has been added to fix the issue.
|
@vanmaegima fixed the changes. |
vanmaegima
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
@kprosise ready to merge |
|
LGTM, Thanks @mmaddala and @vanmaegima |
kprosise
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Template and Checklist
Please complete as much as possible to speed up the reviewing process.
Readiness and adding reviewers as appropriate is required.
All PRs should be reviewed by a technical writer/documentation team and a peer.
If effecting customers—which is a majority of content changes—a member of Customer Success must also review.
Readiness
Overview
Why merge this PR? What does it solve?
Checklist
make linkcheck.-s, --signoff).-S, --gpg-sign).Comments
Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.