Skip to content

Conversation

@mmaddala
Copy link
Contributor

Updated test messages to match previously used phrasing for clarity. Modified docker-compose.yml to reflect these message updates. This ensures consistency across logs and prevents confusion.

PR Template and Checklist

Please complete as much as possible to speed up the reviewing process.

Readiness and adding reviewers as appropriate is required.

All PRs should be reviewed by a technical writer/documentation team and a peer.
If effecting customers—which is a majority of content changes—a member of Customer Success must also review.

Readiness

  • Merge (pending reviews)
  • Merge after date or event
  • Draft

Overview

Why merge this PR? What does it solve?

Checklist

  • Run spelling and grammar check, preferably with linter.
  • Avoid changing any header associated with a link/reference.
  • Step through instructions (or ask someone to do so).
  • Review for wordiness
  • Match tone and style of page/section.
  • Run make linkcheck.
  • View HTML in a browser to check rendering.
  • Use semantic newlines.
  • follow best practices for commits.
    • Descriptive title written in the imperative.
    • Include brief overview of QA steps taken.
    • Mention any related issues numbers.
    • End message with sign off/DCO line (-s, --signoff).
    • Sign commit with your gpg key (-S, --gpg-sign).
    • Squash commits if needed.
  • Request PR review by a technical writer and at least one peer.

Comments

Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.

@mmaddala mmaddala requested review from a team, caiotpereira and vanmaegima September 15, 2025 08:07
Copy link
Contributor

@caiotpereira caiotpereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmaddala, please add the changes on line 131.

@kprosise
Copy link
Contributor

Build and linkcheck failures unrelated to changes and can be ignored

Copy link
Contributor

@kprosise kprosise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you! This discrepancy happened because of changes I made, so I appreciate you catching and fixing it!

Copy link
Member

@vanmaegima vanmaegima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vanmaegima
Copy link
Member

@kprosise ok to merge!

@kprosise
Copy link
Contributor

@mmaddala could you squash/fixup the commits?

Updated test messages to match previously used phrasing for clarity.
Modified docker-compose.yml to reflect these message updates.
This ensures consistency across logs and prevents confusion.
@mmaddala
Copy link
Contributor Author

Done @kprosise

@kprosise kprosise merged commit b463d7b into foundriesio:main Sep 18, 2025
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants