Skip to content

Conversation

@doanac
Copy link
Member

@doanac doanac commented Sep 18, 2025

The device-gateway now includes DeviceGroupId in every event. It also now sends an event every time a device is seen.

PR Template and Checklist

Please complete as much as possible to speed up the reviewing process.

Readiness and adding reviewers as appropriate is required.

All PRs should be reviewed by a technical writer/documentation team and a peer.
If effecting customers—which is a majority of content changes—a member of Customer Success must also review.

Readiness

  • [ x ] Merge (pending reviews)
  • Merge after date or event
  • Draft

Overview

Why merge this PR? What does it solve?

Checklist

  • Run spelling and grammar check, preferably with linter.
  • Avoid changing any header associated with a link/reference.
  • Step through instructions (or ask someone to do so).
  • Review for wordiness
  • Match tone and style of page/section.
  • Run make linkcheck.
  • View HTML in a browser to check rendering.
  • Use semantic newlines.
  • follow best practices for commits.
    • Descriptive title written in the imperative.
    • Include brief overview of QA steps taken.
    • Mention any related issues numbers.
    • End message with sign off/DCO line (-s, --signoff).
    • Sign commit with your gpg key (-S, --gpg-sign).
    • Squash commits if needed.
  • Request PR review by a technical writer and at least one peer.

Comments

Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.

@doanac
Copy link
Member Author

doanac commented Sep 18, 2025

@caiotpereira - this is in production and should be the main changes you were needing.

Copy link
Contributor

@kprosise kprosise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

The device-gateway now includes `DeviceGroupId` in every event. It also
now sends an event every time a device is seen.

Signed-off-by: Andy Doan <andy@foundries.io>
@doanac
Copy link
Member Author

doanac commented Sep 23, 2025

rebased on latest main

@doanac doanac merged commit 3121b49 into foundriesio:main Sep 23, 2025
1 of 3 checks passed
@doanac doanac deleted the event-queus-update branch September 23, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants