start: Retry completion of successfully started update #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-sul
force-pushed
the
msul-retry-update-completion
branch
from
538fe5b to
3e73127
Compare
Collaborator
Author
|
Depends on foundriesio/composeapp#105. |
detsch
approved these changes
Nov 21, 2025
Update completion (uninstalling and removing dangling blobs) may fail under unexpected condition after successful update start. It makes sense to retry the completion in such the case, and if it fails again then retry without dangling blobs pruning. If it still fails then do the force update completion, so the update is considered as a successful and a user can do new updates. Signed-off-by: Mike Sul <mike.sul@foundries.io>
If an update was interrupted in the middle of the "completion" state then allow to go through the update state again down to the "complete" state so the update can be actually properly completed. Signed-off-by: Mike Sul <mike.sul@foundries.io>
mike-sul
force-pushed
the
msul-retry-update-completion
branch
from
7eb2b04 to
384f400
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update completion (uninstalling and removing dangling blobs) may fail under unexpected condition after successful update start. It makes sense to retry the completion in such the case, and if it fails again then retry without dangling blobs pruning.
If it still fails then do enforced update completion, so the update is considered as a successful.