feat(lint): fail on configured diagnostic level

[0xrusowsky]

Motivation

ref:

• feat(forge-lint): return non-zero exit code when lint fails #11393

Solution

• introduce a new deny config flag

   /// Diagnostic level (minimum) at which the process should finish with a non-zero exit.
   pub enum DenyLevel {
       /// Always exit with zero code.
       #[default]
   	Never,
       /// Exit with a non-zero code if any warnings are found.
   	Warnings,
       /// Exit with a non-zero code if any notes or warnings are found.
   	Notes,
   }

• modify the Linter trait so that fn lint() returns an error based on the deny flag and the emitted diagnostics.

   fn lint(&self, input: &[PathBuf], deny: DenyLevel, compiler: &mut Compiler) -> Result<()>

PR Checklist

• Added Tests
• Added Documentation
• Breaking changes: NOT YET. However, introduces a user warning explaining that we decided to remove the --deny-warnings flag in favor of a new --deny flag that takes the DenyLevel.

TODO:

• remove solar patch when 0.1.7 is released --> needed for feat(diagnostics): track notes + expose notes/warn counts paradigmxyz/solar#447
• update docs to reflect --deny-warnings deprecation

[grandizzy]

makes sense, left couple of minor nits

[grandizzy]

@0xrusowsky should we also add tests for forge build with lint set to fail and make sure build pass / fail?

[grandizzy]

lgtm, pending others review / solar bump and update

[DaniPopes]

we also have --deny-warnings, do we also integrate this?

[0xrusowsky]

we also have --deny-warnings, do we also integrate this?

sure. should it fail with Level::Note too? or just Level:Warning?

[DaniPopes]

warnings. could we also rename to keep it consistent? --deny warnings/notes

[DaniPopes]

lgtm, minor adjustments, pending solar release

[onbjerg]

smol nits otherwise lgtm

stale