-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat(forge
): backtraces
#11547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
yash-atreya
wants to merge
33
commits into
master
Choose a base branch
from
yash/forge-backtraces
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat(forge
): backtraces
#11547
+2,251
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion to identify multiple contract / libs accurately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-testing
Area: testing
C-forge
Command: forge
Cmd-forge-test
Command: forge test
T-feature
Type: feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #2328
Forge lacks backtraces, which are useful for pinpointing the line where the revert/error originated in the call stack. This is especially useful when there are multiple nested calls between different contracts, making traces hard to follow. Backtraces help you easily "goto" the line throwing the error.
Solution
forge test
verbosity >= 3
and printed if there is a revertverbosity >= 3
, we collect the source maps, deployed bytecode, and source content.extract_backtraces
; thebytecode.pc
(program counter) is mapped to the instruction pointer and then source maps are used to pinpoint the source locations in the call stack.BacktraceFrame
containing the source location of the call along with the contract and function names.Implementation can be tested using:
foundryup --pr 11547
forge t -vvv
wip
TODOs
ETHERSCAN_API_KEY
c9ce5bcPR Checklist