Skip to content

fix(chisel): guard inspect() behind do_execute to avoid redundant compile/execute #12558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(chisel): guard inspect() behind do_execute to avoid redundant compile/execute #12558

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions crates/chisel/src/dispatcher.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,15 +132,16 @@ impl ChiselDispatcher {
// Create new source with exact input appended and parse
let (new_source, do_execute) = source.clone_with_new_line(input.to_string())?;

// TODO: Cloning / parsing the session source twice on non-inspected inputs kinda sucks.
// Should change up how this works.
let (cf, res) = source.inspect(input).await?;
if let Some(res) = &res {
let _ = sh_println!("{res}");
}
if cf.is_break() {
debug!(%input, ?res, "inspect success");
return Ok(ControlFlow::Continue(()));
// Only inspect when the snippet is appended to run() and will be executed.
if do_execute {
let (cf, res) = source.inspect(input).await?;
if let Some(res) = &res {
let _ = sh_println!("{res}");
}
if cf.is_break() {
debug!(%input, ?res, "inspect success");
return Ok(ControlFlow::Continue(()));
}
}

if do_execute {
Expand Down
Loading