Skip to content

Conversation

@mablr
Copy link
Contributor

@mablr mablr commented Nov 14, 2025

Motivation

Deprecate https://ethereum.github.io/beacon-APIs/#/Beacon/getBlobSidecars

Refactor the Beacon API impl to make it leaner.

Solution

  • Removed useless BeaconResponse, rely instead on alloy_rpc_types_beacon crate response structs
  • Move BeaconError in anvil/src/server mod, to mirror perfectly the Beacon/JSON-RPC handler/error submodules structure
  • updated the test accordingly

PR Checklist

  • Added Tests (updated)
  • Added Documentation (updated)
  • Breaking changes (/eth/v1/beacon/blob_sidecars/{block_id} endpoint deprecated)

- Removed useless `BeaconResponse`,  rely instead on `alloy_rpc_types_beacon` crate response structs
- Move `BeaconError` in `anvil/src/server` mod, to mirror perfectly the Beacon/JSON-RPC handler/error submodules structure
- updated the test accordingly
Copy link
Contributor Author

@mablr mablr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure if we want to get rid of anvil_getBlobSidecarsByBlockId on JSON-RPC ...

@mattsse mattsse added this pull request to the merge queue Nov 17, 2025
Merged via the queue into foundry-rs:master with commit a335575 Nov 17, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this to Done in Foundry Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants