Skip to content

fix(cheatcodes): avoid unnecessary clone in create_end when merging recorded account diffs #12571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+3 −3
Closed

fix(cheatcodes): avoid unnecessary clone in create_end when merging recorded account diffs #12571

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions crates/cheatcodes/src/inspector.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1812,7 +1812,7 @@ impl Inspector<EthEvmContext<&mut dyn DatabaseExt>> for Cheatcodes {
if let Some(recorded_account_diffs_stack) = &mut self.recorded_account_diffs_stack {
// The root call cannot be recorded.
if curr_depth > 0
&& let Some(last_depth) = &mut recorded_account_diffs_stack.pop()
&& let Some(mut last_depth) = recorded_account_diffs_stack.pop()
{
// Update the reverted status of all deeper calls if this call reverted, in
// accordance with EVM behavior
Expand Down Expand Up @@ -1852,9 +1852,9 @@ impl Inspector<EthEvmContext<&mut dyn DatabaseExt>> for Cheatcodes {
// vector if higher depths were not recorded. This
// preserves ordering of accesses.
if let Some(last) = recorded_account_diffs_stack.last_mut() {
last.append(last_depth);
last.append(&mut last_depth);
} else {
recorded_account_diffs_stack.push(last_depth.clone());
recorded_account_diffs_stack.push(last_depth);
}
}
}
Expand Down
Loading