Skip to content

Conversation

@Schamper
Copy link
Member

@Schamper Schamper commented Nov 27, 2025

Closes #96

Also further cleanup of some of the compression unit and benchmark tests.

@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

❌ Patch coverage is 0% with 53 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (2a4d60a) to head (2b1bcf4).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/util/compression/snappy.py 0.00% 53 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #109   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         27      28    +1     
  Lines       1967    2020   +53     
=====================================
- Misses      1967    2020   +53     
Flag Coverage Δ
unittests 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 27, 2025

Merging this PR will not alter performance

✅ 12 untouched benchmarks
🆕 21 new benchmarks
⏩ 16 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
🆕 test_benchmark_lz4_decompress[python-basic] N/A 65.2 µs N/A
🆕 test_benchmark_lzbitmap_decompress[large] N/A 12.9 ms N/A
🆕 test_benchmark_lzbitmap_decompress[uncompressed] N/A 39.2 µs N/A
🆕 test_benchmark_snappy_decompress[basic] N/A 63.7 µs N/A
🆕 test_benchmark_lzxpress_huffman_decompress[large] N/A 5.9 ms N/A
🆕 test_benchmark_lzfse_decompress[large] N/A 5.9 ms N/A
🆕 test_benchmark_lzbitmap_decompress[small] N/A 202.5 µs N/A
🆕 test_benchmark_lz4_decompress[python-large] N/A 170 µs N/A
🆕 test_benchmark_lzxpress_decompress[basic] N/A 143.5 µs N/A
🆕 test_benchmark_snappy_decompress[large] N/A 815.3 µs N/A
🆕 test_benchmark_lzo_decompress[python-larger] N/A 3.1 ms N/A
🆕 test_benchmark_lzo_decompress[python-large] N/A 588.6 µs N/A
🆕 test_benchmark_lzo_decompress[python-header] N/A 38.7 µs N/A
🆕 test_benchmark_lzo_decompress[python-basic] N/A 97.6 µs N/A
🆕 test_benchmark_lzfse_decompress[basic] N/A 199.4 µs N/A
🆕 test_benchmark_lznt1_decompress[large] N/A 3.8 ms N/A
🆕 test_benchmark_lznt1_decompress[basic] N/A 104.2 µs N/A
🆕 test_benchmark_lzvn_decompress[large] N/A 1.3 ms N/A
🆕 test_benchmark_lzxpress_huffman_decompress[basic] N/A 2.6 ms N/A
🆕 test_benchmark_lzxpress_decompress[large] N/A 540.2 µs N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.


Comparing snappy (2b1bcf4) with main (2a4d60a)

Open in CodSpeed

Footnotes

  1. 16 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Schamper Schamper merged commit 66c2619 into main Jan 29, 2026
32 checks passed
@Schamper Schamper deleted the snappy branch January 29, 2026 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Snappy (de)compression algorithm

3 participants