Skip to content

Conversation

@yunzheng
Copy link
Member

Previously, OverlayStream would ignore overlays added at offset 0 because of an incorrect truthiness check (if next_overlay_offset:). This caused the offset 0 to be treated as False (no overlay).

This PR changes the check to explicitly verify if next_overlay_offset is not None:.
It also adds a regression test to ensure overlays at offset 0 work as expected.

fixes #115

@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (ab87cdf) to head (9fe2698).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/util/stream.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #116   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         27      27           
  Lines       1967    1967           
=====================================
  Misses      1967    1967           
Flag Coverage Δ
unittests 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 28, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing bugfix/overlay-offset-0 (9fe2698) with main (ab87cdf)

Summary

✅ 28 untouched benchmarks

@Schamper Schamper merged commit 2a4d60a into main Jan 29, 2026
34 checks passed
@Schamper Schamper deleted the bugfix/overlay-offset-0 branch January 29, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding an overlay at offset 0 has no effect in OverlayStream

3 participants