Allow OverlayStream overlay at offset 0 #116
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, OverlayStream would ignore overlays added at offset 0 because of an incorrect truthiness check (
if next_overlay_offset:). This caused the offset 0 to be treated as False (no overlay).This PR changes the check to explicitly verify if
next_overlay_offset is not None:.It also adds a regression test to ensure overlays at offset 0 work as expected.
fixes #115