Ui.cpp: always use "%s"-style format for printf()-style functions #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ncuses-6.3` added printf-style function attributes and now makes
it easier to catch cases when user input is used in palce of format
string when built with CFLAGS=-Werror=format-security:
Ui.cpp:293:16: error: format not a string literal and no format arguments [-Werror=format-security]
293 | mvwprintw(w,0,0,msg.c_str());
| ~~~~~~~~~^~~~~~~~~~~~~~~~~~~
Let's wrap all the missing places with "%s" format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ncuses-6.3added printf-style function attributes and now makesit easier to catch cases when user input is used in palce of format
string when built with CFLAGS=-Werror=format-security:
Let's wrap all the missing places with "%s" format.