Conversation
…twork rules, and docs fixes Co-authored-by: fpittelo <3135901+fpittelo@users.noreply.github.com>
Apply PR review comments: Function App identity, Key Vault RBAC, network rules
Merge pull request #93 from fpittelo/dev
Dev to qa
…d North Co-authored-by: fpittelo <3135901+fpittelo@users.noreply.github.com>
Fix: Use GlobalStandard SKU for Azure OpenAI deployment in Switzerland North
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces infrastructure enhancements by making service endpoints configurable and updating the Azure OpenAI API version to the latest preview release.
- Refactored hardcoded service endpoints in the virtual network module to be configurable via variables
- Updated Azure OpenAI API version from
2024-02-15-previewto2024-08-01-previewfor dev environment - Removed Gemini-related GitHub workflow files and configuration (dispatch, invoke, review, triage, scheduled-triage workflows and associated command files)
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| modules/virtual_network/variables.tf | Added new service_endpoints variable with default values for KeyVault and Web services |
| modules/virtual_network/main.tf | Replaced hardcoded service endpoints array with variable reference |
| infra/main.tf | Explicitly defined service endpoints including the new Microsoft.CognitiveServices endpoint |
| infra/variables.tf | Updated Azure OpenAI API version to 2024-08-01-preview for the dev environment |
| .github/workflows/gemini-*.yml | Removed five Gemini workflow files (dispatch, invoke, review, triage, scheduled-triage) |
| .github/commands/gemini-*.toml | Removed four Gemini command configuration files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Owner
Author
|
@copilot open a new pull request to apply changes based on the comments in this thread |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhancement