Skip to content

Catch subs error #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fproldan merged 3 commits into from
Mar 4, 2026
Merged

Catch subs error #936

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f61bc9a
Merge branch 'diamoerp-develop' of https://github.com/fproldan/erpnex…
fproldan Sep 5, 2025
8167b13
Merge branch 'diamoerp-develop' of https://github.com/fproldan/erpnex…
fproldan Mar 4, 2026
44ef0e5
catch
fproldan Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion erpnext/accounts/doctype/subscription/subscription.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -771,6 +771,16 @@ def process(data):
frappe.log_error(title=f"Error al procesar la Suscripción {subscription.name}", message=frappe.get_traceback())
subscription.run_trigger("error")
frappe.db.commit()
except Exception:
frappe.db.rollback()
frappe.db.begin()
frappe.log_error(title=f"Error al procesar la Suscripción {data.get('name')}", message=frappe.get_traceback())
try:
subscription = frappe.get_doc('Subscription', data['name'])
subscription.run_trigger("error")
except Exception:
pass
frappe.db.commit()


def debe_asignar_cae(comprobante):
Expand Down Expand Up @@ -874,4 +884,14 @@ def get_subscription_updates(name):
frappe.db.begin()
frappe.log_error(title=f"Error al procesar la Suscripción {subscription.name}", message=frappe.get_traceback())
subscription.run_trigger("error")
frappe.db.commit()
frappe.db.commit()
except Exception:
frappe.db.rollback()
frappe.db.begin()
frappe.log_error(title=f"Error al procesar la Suscripción {name}", message=frappe.get_traceback())
try:
subscription = frappe.get_doc('Subscription', name)
subscription.run_trigger("error")
except Exception:
pass
frappe.db.commit()
Loading