Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 11 additions & 19 deletions frappe/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -189,21 +189,18 @@ def set_value(doctype: str, name: str | int, fieldname: str | dict[str, Any], va
:param fieldname: fieldname string or JSON / dict with key value pair
:param value: value if fieldname is JSON / dict"""

values = {}
if value is not None:
values = {fieldname: value}
elif isinstance(fieldname, dict):
values = fieldname
elif isinstance(fieldname, str):
try:
values = json.loads(fieldname)
except ValueError:
values = {fieldname: ""}
if fieldname in (frappe.model.default_fields + frappe.model.child_table_fields):
frappe.throw(_("Cannot edit standard fields"))

forbidden = set(frappe.model.default_fields + frappe.model.child_table_fields)
for field in values:
if field in forbidden:
frappe.throw(_("Cannot edit standard fields"))
if not value:
values = fieldname
if isinstance(fieldname, str):
try:
values = json.loads(fieldname)
except ValueError:
values = {fieldname: ""}
else:
values = {fieldname: value}

# check for child table doctype
if not frappe.get_meta(doctype).istable:
Expand Down Expand Up @@ -253,11 +250,6 @@ def save(doc: str | dict[str, Any]):
if isinstance(doc, str):
doc = json.loads(doc)

forbidden = {"docstatus", "idx"}
for field in doc:
if field in forbidden:
frappe.throw(_("Cannot edit standard fields"))

doc = frappe.get_doc(doc)
doc.save()

Expand Down
1 change: 1 addition & 0 deletions frappe/public/scss/desk/list.scss
Original file line number Diff line number Diff line change
Expand Up @@ -644,6 +644,7 @@ input.list-header-checkbox {
.layout-main-section .frappe-list .result-container {
.result {
overflow: hidden;
display: block;
input.list-row-checkbox,
input.list-header-checkbox {
width: 15px !important;
Expand Down
Loading