[pull] develop from frappe:develop#1180
Merged
pull[bot] merged 7 commits intofproldan:developfrom Apr 25, 2026
Merged
Conversation
When a DocType has two or more Link fields pointing back to itself and list view tries to join them, pypika auto-aliased both joins with the same '<table>2' suffix, producing a MySQL 1066 'Not unique table/alias' error. Alias each self-referential join with 'tab<doctype>_<link_fieldname>' so every join gets a unique alias, and use the same aliased table in apply_select so SELECT references resolve correctly.
…lias Mirrors test_ambiguous_linked_tables but with a DocType whose Link fields point back to itself, covering the path where pypika's '2' auto-alias collides on the second self-join.
fix(db_query): unique alias on self-referential Link joins
fix(sidebar): notification panel and icon hover state
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )