Open
Conversation
If reference_doctype and reference_name is getting None then Communication will not link with append_to DocType.
…imap is turned off (frappe#17344) This can happen if email domain is updated - which forcibly updates settings of all email accounts associated with that email domain
(cherry picked from commit b4b6b66) Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com>
This is happening because we enqueue the sendmail task before the current transaction is commited. enqueued task is looking for a document that is not yet commited and thus failing to send mails.
(cherry picked from commit 69c87e5)
(cherry picked from commit a80cf47) # Conflicts: # frappe/core/doctype/communication/email.py
(cherry picked from commit 7b7f74c)
(cherry picked from commit cb97b49)
…pe#16228) This is a semi-automatic backport of pull request frappe#16178 done by [Mergify](https://mergify.com).
…ing users) (fix in version-12 but not in version-13) (frappe#17293) fix: issue frappe#17052 fix in version-12 but not in version-13
(cherry picked from commit d76b5fb)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.