Skip to content

Extend constructor for signer and logger #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HAPXu3 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Extend constructor for signer and logger #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/Esia/OpenId.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
use Psr\Http\Client\ClientInterface;
use Psr\Http\Message\RequestInterface;
use Psr\Log\LoggerAwareTrait;
use Psr\Log\LoggerInterface;
use Psr\Log\NullLogger;
use RuntimeException;

Expand Down Expand Up @@ -48,12 +49,16 @@ class OpenId
*/
private $config;

public function __construct(Config $config, ClientInterface $client = null)
{
public function __construct(
Config $config,
ClientInterface $client = null,
SignerInterface $signer = null,
LoggerInterface $logger = null
) {
$this->config = $config;
$this->client = $client ?? new GuzzleHttpClient(new Client());
$this->logger = new NullLogger();
$this->signer = new SignerPKCS7(
$this->logger = $logger ?? new NullLogger();
$this->signer = $signer ?? new SignerPKCS7(
$config->getCertPath(),
$config->getPrivateKeyPath(),
$config->getPrivateKeyPassword(),
Expand Down