Skip to content

Bump vite dependency to resolve CVE-2025-58752 #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vigneshwerv merged 7 commits into from
Oct 2, 2025
Merged

Bump vite dependency to resolve CVE-2025-58752 #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
54ffc41
Bump vite dependency to resolve CVE-2025-58752
vigneshwerv Oct 2, 2025
9ff6c6f
Add .yarn
vigneshwerv Oct 2, 2025
c122679
Enable corepack
vigneshwerv Oct 2, 2025
52c2f4c
rm .yarn
vigneshwerv Oct 2, 2025
6c873fb
Merge remote-tracking branch 'origin/dev' into resolve-cve-npm-vite
vigneshwerv Oct 2, 2025
ca112d2
don't change the old file mode
vigneshwerv Oct 2, 2025
2aa64a1
Reset perms on the bin file
vigneshwerv Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ jobs:

- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "dir=$(yarn config get cacheFolder)" >> $GITHUB_OUTPUT
run: |
corepack enable
Copy link
Copy Markdown
Contributor Author

@vigneshwerv vigneshwerv Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this now 'cause I've upgraded this repo to use yarn@4 instead of yarn@1. This is line with the rest of codebase

echo "dir=$(yarn config get cacheFolder)" >> $GITHUB_OUTPUT

- uses: actions/cache@v4
id: yarn-cache
Expand Down
1 change: 1 addition & 0 deletions .yarnrc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
nodeLinker: node-modules
6 changes: 4 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"name": "@fragment-dev/node-client",
"sideEffects": false,
"scripts": {
"postinstall": "chmod 644 dist/esm/src/bin.js",
Copy link
Copy Markdown
Contributor Author

@vigneshwerv vigneshwerv Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yarn berry seems to have a bug that resets the permissions on the bin file. I resorted to following the solution mentioned in this comment

Copy link
Copy Markdown
Contributor

@sophiehouser sophiehouser Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niceee

"test": "vitest",
"test:ci": "vitest run",
"gen-clients": "rm -rf ./generated/* && yarn node --loader=ts-node/esm src/codegen.ts",
Expand All @@ -24,7 +25,7 @@
"dset": "3.1.4",
"micromatch": "4.0.8",
"ws": "8.17.1",
"vite": "6.3.5",
"vite": "6.3.6",
"@babel/runtime": "7.27.1",
"@babel/helpers": "7.27.1"
},
Expand Down Expand Up @@ -128,5 +129,6 @@
"accounting",
"money",
"payments"
]
],
"packageManager": "yarn@4.9.2+sha512.1fc009bc09d13cfd0e19efa44cbfc2b9cf6ca61482725eb35bbc5e257e093ebf4130db6dfe15d604ff4b79efd8e1e8e99b25fa7d0a6197c9f9826358d4d65c3c"
}
Loading