Skip to content

Fixed asset compile on Windows#2

Open
parnic wants to merge 1 commit intofragmenta:masterfrom
parnic:master
Open

Fixed asset compile on Windows#2
parnic wants to merge 1 commit intofragmenta:masterfrom
parnic:master

Conversation

@parnic
Copy link

@parnic parnic commented Nov 24, 2018

Filepaths were receiving the Windows \ path separator which caused assets.json to believe there were escape sequences in the strings to be JSONified.

Filepaths were receiving the Windows \ path separator which caused assets.json to believe there were escape sequences in the strings to be JSONified.
@pjebs
Copy link

pjebs commented Dec 6, 2020

@parnic Do you know how the /secrets/assets.json files is meant to look like?

@parnic
Copy link
Author

parnic commented Dec 6, 2020

@parnic Do you know how the /secrets/assets.json files is meant to look like?

Take a look at the MarshalJSON function for each struct.

@pjebs
Copy link

pjebs commented Dec 6, 2020

Which struct?

@pjebs
Copy link

pjebs commented Dec 6, 2020

Have you got a sample file that you can share?

@parnic
Copy link
Author

parnic commented Dec 7, 2020

@pjebs Unfortunately I've stopped using this library since this PR was created. You should be able to run it to see what file it produces. Failing that, here are the MarshalJSON calls used to produce that file.

@pjebs
Copy link

pjebs commented Dec 7, 2020

thanks for your help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants