feat: subcontract code refactor and enhancement#25878
Merged
marination merged 7 commits intofrappe:version-13-hotfixfrom Jun 20, 2021
Merged
feat: subcontract code refactor and enhancement#25878marination merged 7 commits intofrappe:version-13-hotfixfrom
marination merged 7 commits intofrappe:version-13-hotfixfrom
Conversation
rohitwaghchaure
requested review from
deepeshgarg007 and
marination
as code owners
rohitwaghchaure
force-pushed
the
v13-sub-contract-enhancemnet
branch
5 times, most recently
from
1befa32 to
f1a5d81
Compare
rohitwaghchaure
force-pushed
the
v13-sub-contract-enhancemnet
branch
5 times, most recently
from
3a9ab6e to
89ccdc2
Compare
rohitwaghchaure
force-pushed
the
v13-sub-contract-enhancemnet
branch
5 times, most recently
from
8ecdd55 to
5d80602
Compare
Collaborator
Author
|
Dependency frappe/frappe#13439 |
marination
requested changes
Jun 7, 2021
erpnext/buying/report/subcontract_order_summary/subcontract_order_summary.py
Outdated
Show resolved
Hide resolved
rohitwaghchaure
force-pushed
the
v13-sub-contract-enhancemnet
branch
from
c3401b2 to
0db2bb3
Compare
This was referenced Jun 10, 2021
rohitwaghchaure
force-pushed
the
v13-sub-contract-enhancemnet
branch
3 times, most recently
from
d0a5894 to
a5629b0
Compare
rohitwaghchaure
force-pushed
the
v13-sub-contract-enhancemnet
branch
2 times, most recently
from
14ea7cc to
a5fd123
Compare
Collaborator
Author
|
|
rohitwaghchaure
force-pushed
the
v13-sub-contract-enhancemnet
branch
2 times, most recently
from
21c047f to
36babeb
Compare
marination
requested changes
Jun 19, 2021
rohitwaghchaure
force-pushed
the
v13-sub-contract-enhancemnet
branch
from
36babeb to
ea83f33
Compare
… added test cases for purchase invoice
rohitwaghchaure
force-pushed
the
v13-sub-contract-enhancemnet
branch
from
ea83f33 to
f5db407
Compare
marination
approved these changes
Jun 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done code refactoring and introduced new class Subcontracting in new file subcontracting.py
Feature Enhancement
Added Subcontract Order Summary Report
Docs frappe/erpnext_documentation#343